From 753b847fd0341514414851f359a7114ea5f4a6f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20L=C3=B6ffler?= <loeffler@spooner-web.de>
Date: Fri, 18 Aug 2017 11:15:21 +0200
Subject: [PATCH] Shows owner information for security team members

---
 .../Classes/Controller/ExtensionController.php  |  3 +++
 .../Private/Partials/ExtensionSingleInfo.html   |  4 ----
 .../Private/Templates/Extension/Show.html       | 17 +++++++++++++++++
 3 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/html/typo3conf/ext/ter_fe2/Classes/Controller/ExtensionController.php b/html/typo3conf/ext/ter_fe2/Classes/Controller/ExtensionController.php
index 71148311..f6a96aec 100755
--- a/html/typo3conf/ext/ter_fe2/Classes/Controller/ExtensionController.php
+++ b/html/typo3conf/ext/ter_fe2/Classes/Controller/ExtensionController.php
@@ -88,6 +88,9 @@ class ExtensionController extends \T3o\TerFe2\Controller\AbstractController
         $this->versionRepository = $this->objectManager->get(\T3o\TerFe2\Domain\Repository\VersionRepository::class);
         $this->authorRepository = $this->objectManager->get(\T3o\TerFe2\Domain\Repository\AuthorRepository::class);
         $this->ownerRepository = $this->objectManager->get(\TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository::class);
+        $querySettings = $this->objectManager->get(\TYPO3\CMS\Extbase\Persistence\Generic\QuerySettingsInterface::class);
+        $querySettings->setRespectStoragePage(false);
+        $this->ownerRepository->setDefaultQuerySettings($querySettings);
         $this->providerManager = $this->objectManager->get(\T3o\TerFe2\Provider\ProviderManager::class);
         $this->session = $this->objectManager->get(\T3o\TerFe2\Persistence\Session::class);
         $this->persistenceManager = $this->objectManager->get(\TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager::class);
diff --git a/html/typo3conf/ext/ter_fe2/Resources/Private/Partials/ExtensionSingleInfo.html b/html/typo3conf/ext/ter_fe2/Resources/Private/Partials/ExtensionSingleInfo.html
index 96d238ed..7d0e48c2 100644
--- a/html/typo3conf/ext/ter_fe2/Resources/Private/Partials/ExtensionSingleInfo.html
+++ b/html/typo3conf/ext/ter_fe2/Resources/Private/Partials/ExtensionSingleInfo.html
@@ -7,10 +7,6 @@
 	<dd><f:format.date format="%d. %b %Y">{extension.crdate}</f:format.date></dd>
 	<dt><f:translate key="downloads" /></dt>
 	<dd><f:format.number decimals="0" thousandsSeparator="," decimalSeparator=".">{extension.downloads}</f:format.number></dd>
-	<f:security.ifHasRole role="{settings.reviewerGroupUid}">
-		<dt>Owner:</dt>
-		<dd>Name: {owner.name}<br />Email: {owner.email}<br />Username: {owner.username}</dd>
-	</f:security.ifHasRole>
 	<dt><f:translate key="category" /></dt>
 	<dd>
 		<f:if condition="{extension.lastVersion.emCategory}">
diff --git a/html/typo3conf/ext/ter_fe2/Resources/Private/Templates/Extension/Show.html b/html/typo3conf/ext/ter_fe2/Resources/Private/Templates/Extension/Show.html
index 3686bddb..605aa827 100644
--- a/html/typo3conf/ext/ter_fe2/Resources/Private/Templates/Extension/Show.html
+++ b/html/typo3conf/ext/ter_fe2/Resources/Private/Templates/Extension/Show.html
@@ -7,6 +7,23 @@
 	<f:if condition="{extension}">
 		<f:then>
 			<tl:titleTag>{extension.lastVersion.title} ({extension.extKey})</tl:titleTag>
+			<f:security.ifHasRole role="{settings.reviewerGroupUid}">
+				<div class="alert alert-info mb-3" role="alert">
+					<div class="media">
+						<f:format.raw>
+							<tl:gravatar emailAddress="{owner.email}" size="125" />
+						</f:format.raw>
+						<div class="media-body ml-5">
+							<h4>Owner of this extension</h4>
+							<p>
+								<strong>Name:</strong> {owner.name}<br>
+								<strong>Email:</strong> <f:link.email email="{owner.email}">{owner.email}</f:link.email><br>
+								<strong>Username:</strong> {owner.username}
+							</p>
+						</div>
+					</div>
+				</div>
+			</f:security.ifHasRole>
 			<f:if condition="{extension.lastVersion.reviewState} == -2">
 				<div class="alert alert-warning mt-3 mb-3" role="alert">
 					<h4 class="alert-header">
-- 
GitLab