Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
E
extensions.typo3.org
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
62
Issues
62
List
Boards
Labels
Service Desk
Milestones
Iterations
Merge Requests
9
Merge Requests
9
Requirements
Requirements
List
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issue
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
services
extensions.typo3.org
extensions.typo3.org
Commits
77279171
Commit
77279171
authored
Aug 08, 2019
by
Thomas Löffler
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix unit tests after upgrading nikic/php-parser
parent
c6555fe3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
6 deletions
+5
-6
extensions/ter_fe2/Classes/Visitor/ArrayAssurer.php
extensions/ter_fe2/Classes/Visitor/ArrayAssurer.php
+3
-2
extensions/ter_fe2/Tests/Unit/Utility/ArchiveUtilityTest.php
extensions/ter_fe2/Tests/Unit/Utility/ArchiveUtilityTest.php
+2
-4
No files found.
extensions/ter_fe2/Classes/Visitor/ArrayAssurer.php
View file @
77279171
...
...
@@ -47,7 +47,7 @@ class ArrayAssurer extends \PhpParser\NodeVisitorAbstract
}
}
// We must not have another assignment
throw
new
\
UnexpectedValueException
()
;
return
\
PhpParser\NodeTraverser
::
REMOVE_NODE
;
}
if
(
!
(
$node
instanceof
Node\Name
...
...
@@ -57,9 +57,10 @@ class ArrayAssurer extends \PhpParser\NodeVisitorAbstract
||
$node
instanceof
Expr\ArrayItem
||
$node
instanceof
Expr\ConstFetch
||
$node
instanceof
Expr\Variable
||
$node
instanceof
Node\Stmt\Expression
)
)
{
return
false
;
return
\
PhpParser\NodeTraverser
::
REMOVE_NODE
;
}
}
}
extensions/ter_fe2/Tests/Unit/Utility/ArchiveUtilityTest.php
View file @
77279171
...
...
@@ -73,10 +73,9 @@ class ArchiveUtilityTest extends \Nimut\TestingFramework\TestCase\UnitTestCase
/**
* @test
*/
public
function
extractEmConfReturns
SaveArrayOnly
ForInvalidNodeFunction
()
public
function
extractEmConfReturns
Null
ForInvalidNodeFunction
()
{
$code
=
'<?php $EM_CONF[$_EXTKEY] = array(\'bar\' => \'baz\'); function foo() {} ?>'
;
$expected
=
[
'bar'
=>
'baz'
];
$subject
=
$this
->
getAccessibleMock
(
\
T3o\TerFe2\Utility\ArchiveUtility
::
class
,
...
...
@@ -84,8 +83,7 @@ class ArchiveUtilityTest extends \Nimut\TestingFramework\TestCase\UnitTestCase
);
$emConf
=
$subject
->
_call
(
'extractEmConf'
,
$code
);
$this
->
assertNotNull
(
$emConf
);
$this
->
assertSame
(
$expected
,
$emConf
);
$this
->
assertNull
(
$emConf
);
}
/**
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment