Merge branch 'add-possibility-for-security-team-upload-extensions' into 'develop'

Add possibility for Security Team members to upload any extension

See merge request t3o/ter!279

html/typo3conf/ext/ter/class.tx_ter_helper.php

@@ -157,14 +157,29 @@ class tx_ter_helper
             throw new \T3o\Ter\Exception\UnauthorizedException('The specified user does not exist. You need to login first on extensions.typo3.org.', TX_TER_ERROR_GENERAL_USERNOTFOUND);
         }
 
-        $row['admin'] = (intval($this->pluginObj->conf['adminFrontendUsergroupUid']) && GeneralUtility::inList(
-            $row['usergroup'],
-            $this->pluginObj->conf['adminFrontendUsergroupUid']
-        ));
+        $row['admin'] = $this->userIsAdmin($row['usergroup']) || $this->userIsSecurityTeamMember($row['usergroup']);
 
         return $row;
     }
 
+    /**
+     * @param string $userGroupList
+     * @return bool
+     */
+    private function userIsAdmin(string $userGroupList): bool
+    {
+        return $this->pluginObj->conf['adminFrontendUsergroupUid'] > 0 && GeneralUtility::inList($userGroupList, (int)$this->pluginObj->conf['adminFrontendUsergroupUid']);
+    }
+
+    /**
+     * @param string $userGroupList
+     * @return bool
+     */
+    private function userIsSecurityTeamMember(string $userGroupList): bool
+    {
+        return $this->pluginObj->conf['securityTeamFrontendUsergroupUid'] > 0 && GeneralUtility::inList($userGroupList, (int)$this->pluginObj->conf['securityTeamFrontendUsergroupUid']);
+    }
+
     /**
      * We check whether a user is logged in by TYPO3
      * because of a sent session cookie

html/typo3conf/ext/ter/resources/static/constants.txt

@@ -2,6 +2,7 @@ plugin.tx_ter_pi1 {
     pid =
     reviewersFrontendUsergroupUid = 2
     adminFrontendUsergroupUid = 3
+    securityTeamFrontendUsergroupUid = 22
     mirrorsFrontendUsergroupUid =
     wsdlNamespace =
 }

html/typo3conf/ext/ter/resources/static/setup.txt

@@ -2,6 +2,7 @@ plugin.tx_ter_pi1 {
     pid = {$plugin.tx_ter_pi1.pid}
     reviewersFrontendUsergroupUid = {$plugin.tx_ter_pi1.reviewersFrontendUsergroupUid}
     adminFrontendUsergroupUid = {$plugin.tx_ter_pi1.adminFrontendUsergroupUid}
+    securityTeamFrontendUsergroupUid = {$plugin.tx_ter_pi1.securityTeamFrontendUsergroupUid}
     mirrorsFrontendUsergroupUid = {$plugin.tx_ter_pi1.mirrorsFrontendUsergroupUid}
     wsdlNamespace = {$plugin.tx_ter_pi1.wsdlNamespace}
 }