Merge branch 'beautifying-detail-view' into 'develop'

Beautifying detail view

See merge request !96

html/typo3conf/ext/ter_fe2/Resources/Private/Partials/ExtensionSingleInfo.html

 {namespace terfe2=T3o\TerFe2\ViewHelpers}
 
-<dl class="row">
-	<dt class="col-sm-4"><f:translate key="version" /></dt>
-	<dd class="col-sm-8">{extension.lastVersion.versionString}</dd>
-	<dt class="col-sm-4">Last update</dt>
-	<dd class="col-sm-8"><f:format.date format="%d. %b %Y">@{extension.lastVersion.uploadDate}</f:format.date></dd>
-	<dt class="col-sm-4"><f:translate key="first_upload" /></dt>
-	<dd class="col-sm-8"><f:format.date format="%d. %b %Y">{extension.crdate}</f:format.date></dd>
-	<dt class="col-sm-4"><f:translate key="downloads" /></dt>
-	<dd class="col-sm-8"><f:format.number decimals="0" thousandsSeparator="," decimalSeparator=".">{extension.downloads}</f:format.number></dd>
+<dl class="dl-horizontal">
+	<dt>Last update</dt>
+	<dd><f:format.date format="%d. %b %Y">@{extension.lastVersion.uploadDate}</f:format.date></dd>
+	<dt><f:translate key="first_upload" /></dt>
+	<dd><f:format.date format="%d. %b %Y">{extension.crdate}</f:format.date></dd>
+	<dt><f:translate key="downloads" /></dt>
+	<dd><f:format.number decimals="0" thousandsSeparator="," decimalSeparator=".">{extension.downloads}</f:format.number></dd>
 	<f:security.ifHasRole role="{settings.reviewerGroupUid}">
-		<dt class="col-sm-4">Owner:</dt>
-		<dd class="col-sm-8">Name: {owner.name}<br />Email: {owner.email}<br />Username: {owner.username}</dd>
+		<dt>Owner:</dt>
+		<dd>Name: {owner.name}<br />Email: {owner.email}<br />Username: {owner.username}</dd>
 	</f:security.ifHasRole>
-	<dt class="col-sm-4"><f:translate key="category" /></dt>
-	<dd class="col-sm-8">
+	<dt><f:translate key="category" /></dt>
+	<dd>
 		<f:if condition="{extension.lastVersion.emCategory}">
 			<f:then>
 				<f:translate key="category_{extension.lastVersion.emCategory}" />
@@ -24,12 +22,18 @@
 			</f:else>
 		</f:if>
 	</dd>
-	<dt class="col-sm-4"><f:translate key="dependencies" /></dt>
-	<dd class="col-sm-8"><f:render partial="InlineRelationList" arguments="{relations: extension.lastVersion.dependencies}" /></dd>
-	<dt class="col-sm-4"><f:translate key="conflicts" /></dt>
-	<dd class="col-sm-8"><f:render partial="InlineRelationList" arguments="{relations: extension.lastVersion.conflicts}" /></dd>
-	<dt class="col-sm-4"><f:translate key="manual" /></dt>
-	<dd class="col-sm-8">
+	<dt><f:translate key="dependencies" /></dt>
+	<dd><f:render partial="InlineRelationList" arguments="{relations: extension.lastVersion.dependencies}" /></dd>
+	<f:if condition="{extension.lastVersion.conflicts}">
+		<dt>
+			<f:translate key="conflicts" />
+		</dt>
+		<dd>
+			<f:render partial="InlineRelationList" arguments="{relations: extension.lastVersion.conflicts}" />
+		</dd>
+	</f:if>
+	<dt><f:translate key="manual" /></dt>
+	<dd>
 		<f:if condition="{documentationLink}">
 			<f:then>
 				<terfe2:raw>{documentationLink}</terfe2:raw>
@@ -55,47 +59,47 @@
 		</f:if>
 		</dd>
 	<f:if condition="{extension.forgeLink}">
-		<dt class="col-sm-4">
+		<dt>
 			<f:translate key="bugtracker" />
 		</dt>
-		<dd class="col-sm-8">
+		<dd>
 			<f:link.external rel="nofollow" uri="{extension.forgeLink}" target="_blank">
 				<f:translate key="found_a_bug" />
 			</f:link.external>
 		</dd>
 	</f:if>
 	<f:if condition="{extension.repositoryUrl}">
-		<dt class="col-sm-4">
+		<dt>
 			<f:translate key="repository_url" />
 		</dt>
-		<dd class="col-sm-8">
+		<dd>
 			<f:link.external rel="nofollow" uri="{extension.repositoryUrl}" target="_blank">
 				<f:translate key="repository_url_value" />
 			</f:link.external>
 		</dd>
 	</f:if>
 	<f:if condition="{flattrUrl}">
-		<dt class="col-sm-4">
+		<dt>
 			<f:translate key="donate" />
 		</dt>
-		<dd class="col-sm-8">
+		<dd>
 			<f:link.external uri="{flattrUrl}" target="_blank"><img
 				src="https://api.flattr.com/button/flattr-badge-large.png"
 				alt="{f:translate(key:'donate')}" /></f:link.external>
 		</dd>
 	</f:if>
 	<f:if condition="{extension.paypalUrl}">
-		<dt class="col-sm-4">
+		<dt>
 			<f:translate key="like_it" />
 		</dt>
-		<dd class="col-sm-8">
+		<dd>
 			<f:link.external rel="nofollow" uri="{extension.paypalUrl}" target="_blank">
 				<f:translate key="donate_url" />
 			</f:link.external>
 		</dd>
 	</f:if>
 	<f:if condition="{extension.lastVersion.author}">
-		<dt class="col-sm-4"><f:translate key="author" /></dt>
-		<dd class="col-sm-8">{extension.lastVersion.author.name}</dd>
+		<dt><f:translate key="author" /></dt>
+		<dd>{extension.lastVersion.author.name}</dd>
 	</f:if>
 </dl>

html/typo3conf/ext/ter_fe2/Resources/Private/Partials/ExtensionUploadHistoryList.html

@@ -15,22 +15,22 @@
 			<f:if condition="{version} == {version.extension.lastVersion}">class="table-success"</f:if>
 			<f:if condition="{version.reviewState} == -1">class="table-danger"</f:if>
 			>
-			<td>
+			<td class="align-middle">
 				<strong>{version.versionString}</strong> / <span class="ter-ext-state-{extension.lastVersion.state}">{extension.lastVersion.state}</span>
 				<br />
 				<small>
 					<f:format.date format="F d, Y">{version.uploadDate}</f:format.date>
 				</small>
 			</td>
-			<td>
+			<td class="align-middle">
 				<f:format.nl2br>{version.uploadComment}</f:format.nl2br>
 			</td>
-			<td>
+			<td class="align-middle">
 				<f:if condition="{version.typo3Dependency}">
 					<strong>{version.typo3Dependency.versionString}</strong>
 				</f:if>
 			</td>
-			<td>
+			<td class="align-middle">
 				<f:if condition="{version.reviewState} != -1">
 					<f:then>
 						<f:link.action controller="Extension" action="download"

html/typo3conf/ext/ter_fe2/Resources/Private/Templates/Extension/Show.html

@@ -16,7 +16,7 @@
 				</div>
 			</f:if>
 
-			<div class="row mt-3">
+			<div class="row mt-3 align-items-center">
 				<div class="col-md-9">
 					<header>
 						<terfe2:extensionIcon version="{extension.lastVersion}" alt="{extension.lastVersion.title}" class="ter-ext-icon" />
@@ -30,35 +30,31 @@
 				</div>
 				<div class="col-md-3">
 					<f:if condition="{extension.lastVersion.reviewState} != -1">
-						<f:link.action class="btn btn-primary pull-right" controller="Extension" action="download" arguments="{extension : extension, versionString : extension.lastVersion.versionString, format : 'zip'}">
+						<f:link.action class="btn btn-primary btn-lg pull-right" controller="Extension" action="download" arguments="{extension : extension, versionString : extension.lastVersion.versionString, format : 'zip'}">
 							Download {extension.lastVersion.versionString}
 						</f:link.action>
 					</f:if>
 				</div>
 			</div>
 
-			<div class="mb-3">
-				<p>{extension.lastVersion.description}</p>
-				<f:if condition="{extension.lastVersion.typo3Dependency}">
-					<p>
-						<strong>
-							This version works for TYPO3 {extension.lastVersion.typo3Dependency.versionString}
-						</strong>
-					</p>
-				</f:if>
-			</div>
-
-			<f:if condition="{extension.tags}">
-				<h3>Tags</h3>
-				<p class="tags">
-					<f:for each="{extension.tags}" as="tag">
-						<f:link.page class="btn btn-info mb-1" additionalParams="{q: '{tag.title}'}">#{tag.title}</f:link.page>
-					</f:for>
-				</p>
-			</f:if>
-
 			<div class="row mb-3">
 				<div class="col-md-8">
+					<p>{extension.lastVersion.description}</p>
+					<f:if condition="{extension.lastVersion.typo3Dependency}">
+						<p>
+							<strong>
+								This version works for TYPO3 {extension.lastVersion.typo3Dependency.versionString}
+							</strong>
+						</p>
+					</f:if>
+					<f:if condition="{extension.tags}">
+						<h3>Tags</h3>
+						<p class="tags">
+							<f:for each="{extension.tags}" as="tag">
+								<f:link.page class="btn btn-info mb-1" additionalParams="{q: '{tag.title}'}">#{tag.title}</f:link.page>
+							</f:for>
+						</p>
+					</f:if>
 					<h3>
 						<f:translate key="last_upload_comment" />
 					</h3>