Change some first stuff extension scanner is complaining

extensions/ter/Classes/Configuration/ExtConf.php

@@ -36,7 +36,7 @@ class ExtConf implements SingletonInterface
     public function __construct()
     {
         // get global configuration
-        $extConf = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['ter']);
+        $extConf = $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['ter'];
         if (is_array($extConf) && count($extConf)) {
             // call setter method foreach configuration entry
             foreach ($extConf as $key => $value) {

extensions/ter/Classes/Task/UpdateCurrentVersionListTask.php

@@ -14,6 +14,7 @@ namespace T3o\Ter\Task;
  * The TYPO3 project - inspiring people to share!
  */
 
+use TYPO3\CMS\Core\Core\Environment;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
@@ -42,7 +43,7 @@ class UpdateCurrentVersionListTask extends \TYPO3\CMS\Extbase\Scheduler\Task
     protected function fetchCurrentCoreData()
     {
         $result = false;
-        $targetFile = PATH_site . $GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] . 'currentcoredata.json';
+        $targetFile = Environment::getPublicPath() . '/' . $GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] . 'currentcoredata.json';
         $sourceData = GeneralUtility::getUrl('http://get.typo3.org/json');
         if (json_decode($sourceData, true) !== null) {
             $result = GeneralUtility::writeFile($targetFile, $sourceData);
@@ -57,7 +58,7 @@ class UpdateCurrentVersionListTask extends \TYPO3\CMS\Extbase\Scheduler\Task
     protected function fetchCurrentDocumentationData()
     {
         $result = false;
-        $targetFile = PATH_site . $GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] . 'currentdocumentationdata.json';
+        $targetFile = Environment::getPublicPath() . '/' . $GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] . 'currentdocumentationdata.json';
         $sourceData = GeneralUtility::getUrl('https://intercept.typo3.com/assets/docs/manuals.json');
         if (json_decode($sourceData, true) !== null) {
             $result = GeneralUtility::writeFile($targetFile, $sourceData);
@@ -76,12 +77,12 @@ class UpdateCurrentVersionListTask extends \TYPO3\CMS\Extbase\Scheduler\Task
     protected function generateExtensionFilesForExtensionManager(): bool
     {
         // Check extension configuration
-        if (empty($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['ter'])) {
+        if (empty($GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['ter'])) {
             throw new \Exception('No extension configuration found in $TYPO3_CONF_VARS', 1303220916);
         }
 
         // Check extension repository path
-        $extensionConfig = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['ter']);
+        $extensionConfig = $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['ter'];
         if (empty($extensionConfig['repositoryDir'])) {
             throw new \Exception('No repository path found in extension configuration', 1303220917);
         }

extensions/ter/Configuration/TCA/tx_ter_extensiondetails.php

@@ -19,7 +19,7 @@ return [
         'label_userFunc' => 'EXT:ter/class.tx_ter_tcaLabel.php:tx_ter_tcaLabel->getExtensionKey',
         'default_sortby' => 'ORDER BY extensionuid',
         'title' => 'LLL:EXT:ter/locallang_tca.xml:tx_ter_extensiondetails',
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($extensionKey) . 'tx_ter_extensiondetails.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath($extensionKey)) . 'tx_ter_extensiondetails.gif',
         'dividers2tabs' => true,
     ],
     'interface' => [

extensions/ter/Configuration/TCA/tx_ter_extensionkeys.php

@@ -20,7 +20,7 @@ return [
         'tstamp' => 'tstamp',
         'crdate' => 'crdate',
         'title' => 'LLL:EXT:ter/locallang_tca.xml:tx_ter_extensionkeys',
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($extensionKey) . 'tx_ter_extensionkeys.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath($extensionKey)) . 'tx_ter_extensionkeys.gif',
         'dividers2tabs' => true,
     ],
     'interface' => [

extensions/ter/Configuration/TCA/tx_ter_extensionmembers.php

@@ -18,7 +18,7 @@ return [
         'label' => 'extensionkey',
         'default_sortby' => 'ORDER BY extensionkey',
         'title' => 'LLL:EXT:ter/locallang_tca.xml:tx_ter_extensionmembers',
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($extensionKey) . 'tx_ter_extensionmembers.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath($extensionKey)) . 'tx_ter_extensionmembers.gif',
         'dividers2tabs' => true,
     ],
     'interface' => [

extensions/ter/Configuration/TCA/tx_ter_extensionqueue.php

@@ -21,7 +21,7 @@ return [
         'tstamp' => 'tstamp',
         'delete' => 'deleted',
         'title' => 'LLL:EXT:ter/locallang_tca.xml:tx_ter_extensionqueue',
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($extensionKey) . 'tx_ter_extensionqueue.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath($extensionKey)) . 'tx_ter_extensionqueue.gif',
         'dividers2tabs' => true,
     ],
     'interface' => [

extensions/ter/Configuration/TCA/tx_ter_extensions.php

@@ -20,7 +20,7 @@ return [
         'tstamp' => 'tstamp',
         'crdate' => 'crdate',
         'title' => 'LLL:EXT:ter/locallang_tca.xml:tx_ter_extensions',
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($extensionKey) . 'tx_ter_extensions.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath($extensionKey)) . 'tx_ter_extensions.gif',
         'dividers2tabs' => true,
     ],
     'interface' => [

extensions/ter/class.tx_ter_tcaLabel.php

@@ -33,11 +33,14 @@ class tx_ter_tcaLabel
             return;
         }
 
-        $result = $GLOBALS['TYPO3_DB']->exec_SELECTgetSingleRow(
-            'extensionkey',
-            'tx_ter_extensions',
-            'uid=' . (int)$params['row']['uid']
-        );
+        $result = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Database\ConnectionPool::class)
+            ->getConnectionForTable('tx_ter_extensions')
+            ->select(
+                ['extensionkey'],
+                'tx_ter_extensions',
+                ['uid = ' . (int)$params['row']['uid']]
+            )
+            ->fetch();
 
         if (!empty($result['extensionkey'])) {
             $params['title'] = htmlspecialchars($result['extensionkey']);

extensions/ter/pi1/class.tx_ter_pi1.php

@@ -30,11 +30,8 @@
  * TOTAL FUNCTIONS: 1
  * (This index is automatically created/updated by the extension "extdeveval")
  */
-use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\CMS\Frontend\Plugin\AbstractPlugin;
 
-require_once(ExtensionManagementUtility::extPath('ter') . 'class.tx_ter_api.php');
-
 /**
  * TYPO3 Extension Repository, frontend plugin for SOAP service
  *
@@ -50,14 +47,12 @@ class tx_ter_pi1 extends AbstractPlugin
 
     public function main($content, $conf)
     {
-        global $TSFE;
-
         $this->pi_initPIflexForm();
         $this->conf = $conf;
 
         $this->extensionsPID = $conf['pid'];
         $this->wsdlNamespace = $conf['wsdlNamespace'];
-        $staticConfArr = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['ter']);
+        $staticConfArr = $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['ter'];
         if (is_array($staticConfArr)) {
             $this->repositoryDir = $staticConfArr['repositoryDir'];
             if (substr($this->repositoryDir, -1, 1) != '/') {

extensions/ter/tx_ter_wsdl.php

@@ -31,9 +31,8 @@ define('PATH_thisScript', str_replace('//', '/', str_replace(
     (php_sapi_name() == 'cgi' || php_sapi_name() == 'isapi' || php_sapi_name() == 'cgi-fcgi') && ($_SERVER['ORIG_PATH_TRANSLATED'] ? $_SERVER['ORIG_PATH_TRANSLATED'] : $_SERVER['PATH_TRANSLATED']) ? ($_SERVER['ORIG_PATH_TRANSLATED'] ? $_SERVER['ORIG_PATH_TRANSLATED'] : $_SERVER['PATH_TRANSLATED']) : ($_SERVER['ORIG_SCRIPT_FILENAME'] ? $_SERVER['ORIG_SCRIPT_FILENAME'] : $_SERVER['SCRIPT_FILENAME'])
 )));
 
-define('PATH_site', str_replace(['/wsdl', '/typo3conf/ext/ter'], '', dirname(PATH_thisScript)) . '/');
+define('PATH_site', str_replace(['/wsdl', '/typo3conf/ext/ter'], '', dirname(\TYPO3\CMS\Core\Core\Environment::getCurrentScript())) . '/');
 define('PATH_typo3', PATH_site . 'typo3/');
-define('PATH_tslib', PATH_typo3 . 'sysext/cms/tslib/');
 define('PATH_typo3conf', PATH_site . 'typo3conf/');
 define('TYPO3_mainDir', 'typo3/');
 

extensions/ter_fe2/Configuration/TCA/tx_terfe2_domain_model_author.php

@@ -16,7 +16,7 @@ return [
         'enablecolumns' => [
             'disabled' => 'hidden'
         ],
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath('ter_fe2') . 'Resources/Public/Icons/author.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('ter_fe2')) . 'Resources/Public/Icons/author.gif',
     ],
     'interface' => [
         'showRecordFieldList' => 'name,email,company,forge_link,username,versions,frontend_user,author_type',

extensions/ter_fe2/Configuration/TCA/tx_terfe2_domain_model_extension.php

@@ -16,7 +16,7 @@ return [
         'enablecolumns' => [
             'disabled' => 'hidden'
         ],
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath('ter_fe2') . 'Resources/Public/Icons/extension.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('ter_fe2')) . 'Resources/Public/Icons/extension.gif',
     ],
     'interface' => [
         'showRecordFieldList' => 'ext_key,forge_link,last_update,last_maintained,tags,versions,last_version,frontend_user,downloads,composer_name,repository_url,paypal_url,external_manual,expire',

extensions/ter_fe2/Configuration/TCA/tx_terfe2_domain_model_relation.php

@@ -16,7 +16,7 @@ return [
         'enablecolumns' => [
             'disabled' => 'hidden'
         ],
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath('ter_fe2') . 'Resources/Public/Icons/relation.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('ter_fe2')) . 'Resources/Public/Icons/relation.gif',
     ],
     'interface' => [
         'showRecordFieldList' => 'relation_type,relation_key,minimum_version,maximum_version',

extensions/ter_fe2/Configuration/TCA/tx_terfe2_domain_model_tag.php

@@ -16,7 +16,7 @@ return [
         'enablecolumns' => [
             'disabled' => 'hidden'
         ],
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath('ter_fe2') . 'Resources/Public/Icons/tag.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('ter_fe2')) . 'Resources/Public/Icons/tag.gif',
     ],
     'interface' => [
         'showRecordFieldList' => 'title,extensions',

extensions/ter_fe2/Configuration/TCA/tx_terfe2_domain_model_version.php

@@ -18,7 +18,7 @@ return [
         'enablecolumns' => [
             'disabled' => 'hidden'
         ],
-        'iconfile' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath('ter_fe2') . 'Resources/Public/Icons/version.gif',
+        'iconfile' => \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('ter_fe2')) . 'Resources/Public/Icons/version.gif',
     ],
     'interface' => [
         'showRecordFieldList' => 'title,description,version_number,version_string,upload_date,upload_comment,download_counter,frontend_download_counter,state,em_category,load_order,priority,shy,internal,do_not_load_in_fe,uploadfolder,clear_cache_on_load,module,create_dirs,modify_tables,lock_type,cgl_compliance,cgl_compliance_note,review_state,manual,has_manual,software_relations,author,file_hash,extension_provider,has_zip_file,has_images,composer_info',

extensions/ter_fe2/ext_tables.php

@@ -30,7 +30,7 @@ call_user_func(function () {
     \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPageTSConfig('
 	mod.wizards.newContentElement.wizardItems.special {\n
 		elements.' . $extIdent . ' {\n
-			icon        = ' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath('ter_fe2') . 'Resources/Public/Images/Wizard.gif\n
+			icon        = ' . \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('ter_fe2')) . 'Resources/Public/Images/Wizard.gif\n
 			title       = LLL:EXT:ter_fe2/Resources/Private/Language/locallang_db.xlf:newContentElement.wizardItem.title\n
 			description = LLL:EXT:ter_fe2/Resources/Private/Language/locallang_db.xlf:newContentElement.wizardItem.description\n\n
 			tt_content_defValues {\n